RSA and Knapsack public-key cipher algorithm are classical encryption algorithms. There are also many people researches about the improvement of them recently. Wang Qian created a knapsack public-key cipher scheme based on RSA. There are a security analysis of the improved algorithm and a analysis form three angles of the scheme in this paper. Finally, we will use the calculation results of the lattice code against to prove that the improved algorithm is still not safe.